Webcore-bits: Height merge for RenderBox

Koos Vriezen koos.vriezen at xs4all.nl
Sat Oct 16 21:52:46 BST 2004


On Sat, Oct 16, 2004 at 09:39:02PM +0200, Allan Sandfeld Jensen wrote:
> Hi again
> 
> Next webcore-patch. The reason I this time post to the mailing list is not 
> confusion, but more than 2600 changed regression-outputs.
> The patch introduces an IE-quirk where the body ends up with the same size as 
> the canvas, this ofcourse affects a lot of regression-tests (but fixes bug 
> 76759)
> 
> The patch also fixes bugs: 76759 (height 100%), 59502(min-height) and 59503
> (max-height). And naturally the quirk-height and minheight tests in the 
> regressionstests from WebCore.
> 
> I should note I also saw a few cases of OverhangingContent flags disappearing, 
> but the cases didn't seem to have overhanging content.

Don't expect any useful comment from me, but as I posted the problems
with map24 today, I though I give it a try. But

$ patch -p0 --dry-run < box-height.diff
patching file rendering/render_box.cpp
patching file rendering/render_box.h
Hunk #3 FAILED at 53.
Hunk #5 FAILED at 175.
2 out of 5 hunks FAILED -- saving rejects to file
rendering/render_box.h.rej

What version do you have?

Koos





More information about the kfm-devel mailing list