patch for iframes with SRC=""

[Koos Vriezen]

On Fri, Sep 03, 2004 at 02:37:55PM +0200, Koos Vriezen wrote:
> On Fri, Sep 03, 2004 at 01:49:57PM +0200, David Faure wrote:
> > There is (konqueror's findFrame stuff etc.). Sounds like your changes broke it :)
> > I lost overview a bit, but do you store the name in khtml::ChildFrame?
> > AFAIU you don't create a khtmlpart for about:blank anymore, so the name has
> > to be stored somewhere else, and KHTMLPart::findFrame has to see it.
> 
> No, I hardly can imagine that I changed any of the creation stuff nor
> should any of the KHTMLPart only trees be affected.

Coincidence or not, but we don't create iframes with empty SRC. I
checked render_frames.cpp.diff?r1=1.162;r2=1.163 and that was 
before my changes already the case.

Anyway this seems to hurt map24.com interactive applet, site works but
no applet. This makes it work again:

--- rendering/render_frames.cpp 9 Aug 2004 08:39:46 -0000       1.185
+++ rendering/render_frames.cpp 1 Oct 2004 13:24:05 -0000
@@ -600,7 +600,7 @@ void RenderPartObject::updateWidget()

       HTMLIFrameElementImpl *o = static_cast<HTMLIFrameElementImpl *>(element());
       url = o->url.string();
-      if( url.isEmpty() || !o->getDocument()->isURLAllowed(url) ) return;
+      if( !url.isEmpty() && !o->getDocument()->isURLAllowed(url) ) return;
       part->requestFrame( this, url, o->name.string(), QStringList(), true );
   // ### this should be constant true - move iframe to somewhere else
   } else {

Objections w/ backport?

> Koos