[PATCH] finally

[George Staikos]

This is the final patch to make KHTML KWallet-asynchronous.  It changes the 
behaviour of KHTMLPart::wallet() slightly in that it returns null more often 
- not really a problem.  It also changes wallet prompting behaviour in a 
minor way:

Previously:
- If the wallet is closed when the user submits a form, it checks to see if 
there is a hit on the key in the wallet.  If so, it asks the user to open the 
wallet so that it can verify the entry does exist and see if the form 
contents changed.  If it exists and is not changed, it skips the wallet and 
goes on submitting the form.  If it doesn't exist or has changed, it prompts 
the user to save.

Now:
- If the wallet is closed when the user submits a form, it prompts the user if 
he would like to save the form to the wallet.  If the wallet is open, then it 
proceeds as above.

I think that the case of a wallet closed during form submit almost always 
means that the user doesn't have anything saved, so they should be prompted 
anyway, which means that it is almost always the case that this patch will 
show no change in behaviour to the user.

One thing this doesn't address is passwordless wallets, which will appear to 
be locked when they are closed, but we could add a feature to automatically 
open them as in the "Previously" case above.

Finally, the code will eventually change to work like this anyway, since we 
will support multiple form entries in the wallet.

Anyone object to this change?

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwallet-finally-async.patch
Type: text/x-diff
Size: 7969 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20041108/fd70fa66/attachment.patch>