[Patch] fix for #67151

Leo Savernik l.savernik at aon.at
Mon May 24 22:56:15 BST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

I've found a quick-fix for br 67151 which keeps border-*-style directives from 
working in table cells of tables with a border="0" attribute.

The fix simply replaces the addCSSProperty(CSS_PROP_BORDER_VALUE, "0") with 
removeCSSProperty(CSS_PROP_BORDER_VALUE) in 
RenderTableCellElementImpl::attach.

Is this patch correct? Please review.

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFAsm9/j5jssenUYTsRAq9UAJ0cGjBnT1YAKaaEBPBs+vuuZehBiQCdHLKh
X0PAemCjlzP0v1Nnt3jner8=
=grj6
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: html/html_tableimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/html/html_tableimpl.cpp,v
retrieving revision 1.181
diff -u -p -r1.181 html_tableimpl.cpp
--- html/html_tableimpl.cpp	12 Feb 2004 23:14:08 -0000	1.181
+++ html/html_tableimpl.cpp	24 May 2004 21:44:21 -0000
@@ -821,7 +821,7 @@ void HTMLTableCellElementImpl::attach()
     if(p) {
         HTMLTableElementImpl* table = static_cast<HTMLTableElementImpl*>(p);
         if (table->m_noBorder) {
-            addCSSProperty(CSS_PROP_BORDER_WIDTH, "0");
+            removeCSSProperty(CSS_PROP_BORDER_WIDTH);
         }
         else {
             addCSSProperty(CSS_PROP_BORDER_WIDTH, "1px");


More information about the kfm-devel mailing list