[PATCH] overwriting location.href

[David Faure]

On Wednesday 19 May 2004 17:51, Tobias Anton wrote:
> Hi,
> 
> If a redirection contains a malformed url or location.href is set multiple 
> times from a piece of javascript code, KHTML ignores every setting of 
> location.href following the first one.
> 
> Example:
> 
> 	location.href="a.html";
> 	location.href="b.html";
> 
> b.html should be opened, but a.html is.

Ouch, how could we miss this...

> The attached patch fixes this. Can I go ahead and commit?

Looks good to me. Did you make a testcase and checked it with other browsers?
Can you add a regression test to khtmltests (simply something like the above, the 
framework will check that it always goes to b.html)?
Maybe in regression/tests/ecma/.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).