key navigation and visible area of the page

[Lubos Lunak]

On Monday 17 of May 2004 11:52, Tobias Anton wrote:
> On Mittwoch, 12. Mai 2004 09:49, Lubos Lunak wrote:
> > On Monday 10 of May 2004 18:40, Arend van Beelen jr. wrote:
> > > On Monday 10 May 2004 18:26, Lubos Lunak wrote:
> > > >  Hello,
> >
> >  scrollTo() patch committed.
>
> Hi,
>
> It seems like you misunderstood Arend's answer.

 No, I did not, I knew it was unrelated. I asked if anybody saw reasons 
against it, and nobody spoke up.

> He was talking about the 
> type-ahead find. I'd like you to revert your patch.
>
> The amount of scrolling is limited to at most one page so that tab can be
> used to view the entire page following the focus order that the author
> intended. It is particularly useful for people that don't use a mouse and I
> don't see a necessity to break the known behaviour for them. If you found
> any bugs in conjunction with type-ahead find or the selection code, please
> report or fix them instead of cutting out working code.

 I already described the problem. The Tab behaviour is weird if the focused 
item is not visible. Go e.g. to 
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/khtmlview.cpp , hit 
Tab few times, scroll ten pages down, and start hitting Tab again. I doubt 
you can guess what it will do, but even if you do, I don't consider that to 
be known behaviour, in fact I was pretty confused when that happened to me.

 But perhaps this problem would go away after changing Tab to start from the 
visible area, like Arend suggested. What's your opinion on this?

>
> If your accesskey code does not work correctly with scrollTo(), I'd suggest
> that you simply use QScrollView::ensureVisible() instead. Adding an
> argument "bool onePage" to the scrollTo function is wrong.

 I found using scrollTo() to be better than ensureVisible() - it takes QRect 
instead of just a point, and seems to be a bit better at positioning. So I'd 
like to keep the onepage argument. Scrolling by one page for accesskeys 
definitely doesn't make sense.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/