[PATCH] GUI for hover close button option

Thomas McGuire thomasmg at web.de
Wed May 12 21:07:09 BST 2004


On Wednesday May 12 2004 20:42, Matt Rogers wrote:
> A good reason of why hover close buttons shouldn't be on by
> default is that (IIRC) the default delay isn't very long and so
> if you click on the favicon while moving the mouse over the tab,
> the window will close even though the button hasn't finished
> being displayed yet. I don't know if this behavior has changed or
> not, but we had the same problem with Kopete and there was even a
> bug report about it.
OK, I'll change this (tomorrow) so that hover close buttons will not 
be on by default.

> As far as the patch goes, I gave it a cursory glance and it
> looked ok to me. I'll have to wait to get home to test it though.
OK, great.
BTW I just noticed that the What's this help text has line break in 
it which should not be there, I'll fix that, too.

> Just as an FYI for next time, It would be better if you just sent
> one patch for all the changes rather than 4 patches. It makes it
> easier to apply that way.  
> Also, rather than having to make a 
> backup directory, you can use cvs diff to see the changes and
> make patches. (see
> http://developer.kde.org/documentation/other/developer-faq.html#q
>1.5.2 for an explanation of what to have in your $HOME/.cvsrc
> file)
OK, you will see the corrected patch tomorrow.

Cheers,
Thomas





More information about the kfm-devel mailing list