[PATCH] GUI for hover close button option

[Matt Rogers]

On Wednesday 12 May 2004 01:00 pm, Thomas McGuire wrote:
> Hello,
>
> As I could not find an option anywhere to enable hover close
> buttons, I created the option myself.
> You can now decide between favicons in tab either with hover close
> button or without by checking a checkbox in Settings/Web
> Behaviour/Advanced Options.
> Permanent close butttons are no longer possible, but I think nobody
> used them anyway.
> Hover close buttons are now enabled by default, as I do not see a
> reason why they should not.
>

A good reason of why hover close buttons shouldn't be on by default is that 
(IIRC) the default delay isn't very long and so if you click on the favicon 
while moving the mouse over the tab, the window will close even though the 
button hasn't finished being displayed yet. I don't know if this behavior has 
changed or not, but we had the same problem with Kopete and there was even a 
bug report about it.

> The modified strings should be checked since my English is not very
> good.
>
> And please note that the "Apply" button does not work with this
> option, but that is the same behaviour like before with the old
> "Permanent close button" option. I really do not where I could
> correct this.
>
> This is my first patch for KDE, I hope I haven't done something
> totally stupid ;-)
> I hope somebody will commit it.
>
> Thanks very much,
> Thomas

As far as the patch goes, I gave it a cursory glance and it looked ok to me. 
I'll have to wait to get home to test it though.


Just as an FYI for next time, It would be better if you just sent one patch 
for all the changes rather than 4 patches. It makes it easier to apply that 
way.  Also, rather than having to make a backup directory, you can use cvs 
diff to see the changes and make patches. (see 
http://developer.kde.org/documentation/other/developer-faq.html#q1.5.2 for an 
explanation of what to have in your $HOME/.cvsrc file)

Matt