[PATCH] Please review, fixes #20194.

Benoit Walter b.walter at free.fr
Thu May 6 22:39:21 BST 2004


The code looks ok to me and I prefer the new behaviour, too. I think a similar 
patch could be proposed to trolltech for consistency reasons with QIconView.
BTW, I was planning to make a few changes in "Extended" selection mode:

- Give focus to the first selected icon (when using selection rect) to avoid 
an unexpected behaviour after selecting another icon with the Shift key.
- Select icons in order (instead of using a rect whose corners are 
selectedItem and currentItem) - see #59228

Again I would prefer those bugs to be solved in Qt, for the moment, the icon 
selection using the shift key is still confusing.

Cheers,
Benoit.

On Thursday 06 May 2004 17:34, Matt Newell wrote:
> This is a patch to kiconview that fixes bug #20194 (shift-clicking causes
> currentItem to change, so further shift-clicks don't extend/reduce the
> selection) and eliminates flicker when shift-clicking.  Should apply to
> current kdelibs cvs.  I will commit it if someone says it looks ok.
>
> Matt




More information about the kfm-devel mailing list