[PATCH] accesskey attribute (#45788)

[Lubos Lunak]

On Tuesday 01 of January 2002 15:51, Dirk Mueller wrote:
> On Thursday 11 March 2004 17:37, Lubos Lunak wrote:
> >  khtmlview.cpp.patch . I hope it's right.
>
> Ok. in khtml.patch, you check for the elementid before checking if an
> accesskey attribute is there. IMHO that shouldn't be done. Otherwise it
> seems okay.

 Replaced that check with just isElementNode(), committed+backported.

>
> >  html_formimpl.cpp.patch - INPUT elements perform the action in
> > activate(), key events are transformed to clicks, clicks are transformed
> > to domactivate events. I hope I got it right, because it's mostly
> > reshuffling of the stuff, but I'm far from being 100% sure about it.
>
> it seems you broke checkboxes, since setChecked() is now called after the
> onclick handler (it has to be done before). This has to be fixed.

 Pffft. I see html is about as simple as window managers. This will need some 
time.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/