Crash in decoder.cpp & CSS loading problem

[Andras Mantia]

Dirk Mueller wrote:

> On Tuesday 02 March 2004 10:26, Andras Mantia wrote:
> 
>>  Updated today and saw that the KHTML part crashes if you call write()
>>  with
>> an empty QString, like write(""). The backtrace shows that the assert in
>> decoder.cpp, line 341 was hit. See below the BT. I assume there was no
>> such assert before as it worked until now.
> 
> The code was that way since KDE 3.1.0 at least.

But the assert was not hit before (as I would have notice that KHTML crashes
when I close a file in Quanta...). I saw a recent commit:

--- kdelibs/khtml/khtml_part.cpp  #1.976:1.977
@@ -1695,10 +1695,10 @@ void KHTMLPart::write( const char *str, 
     d->m_decoder = createDecoder();
 
-  if ( len == 0 )
-    return;
-
   if ( len == -1 )
     len = strlen( str );
 
+  if ( len == 0 )
+    return;
+
   QString decoded = d->m_decoder->decode( str, len );

It might be that this (the old code) triggered the assert?

>>  Also after the recent update the doxygen.css for the API docs is not
>> loaded.
> 
>  did you update branch or HEAD ?

HEAD.

> 
> And which api docs ?
> 
> http://developer.kde.org/documentation/library/cvs-api/index.html ?
> 
> It seems to load it for me. But there was a problem with the documentation
> generation process (which apparently nobody maintains) for the last 2
> weeks.

I had some old API docs, which worked well, but after I upgraded kdelibs, I
see that the CSS is not loaded. I'm running make apidox now to see how it
will behave. BTW, I've tried with:
file:/opt/kde3/share/doc/HTML/en/kdelibs-apidocs/kdecore/html/classKURL.html

Andras