[Patch] inline blocks lineHeight, inline tables positioning, vertical-align fixes

Germain Garand germain at ebooksfrance.org
Thu Jun 24 14:43:23 BST 2004


Hi,
Here is a regression tested patch addressing $subject

Please review,
Germain

* css/html4.css: 
- default tbody/tfoot/thead to vertical-align: middle
as required by spec:
    http://www.w3.org/TR/html401/struct/tables.html#alignment
- do not set vertical-align on the table: it breaks
inline-table's default (baseline).
    cf. fast/inline-block/001.html

* rendering/render_table.h
(position) remove empty reimplementation:
inline-tables need positioning. cf. fast/inline-block/001.html

* rendering/render_object.cpp 
(getVerticalPosition): inverted logic.
    cf. unsorted/RESOLVED-20423-436.html,
    unsorted/74399.html
(lineHeight/baselinePosition): inline-blocks behaves like replaced elements, 
but only after they have been layouted ( i.e when their intrinsic height is 
known). Otherwise, they behave like blocks, hence we query
the block's strut. Avoids the need for WC's isRootLinebox bool.
    cf. fast/inline-block/001.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inline_blocks.diff
Type: text/x-diff
Size: 3255 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040624/448277ac/attachment.diff>


More information about the kfm-devel mailing list