Showing the context menu while a page is loading

David Faure faure at kde.org
Sun Jan 18 00:38:19 GMT 2004


On Saturday 17 January 2004 12:52, Benoit Walter wrote:
> I tried to fix the old and annoying bug number 31779
> (http://bugs.kde.org/votes.cgi?action=show_bug&bug_id=31779)
> and found the following lines in konq_mainwindow.cpp:
> 
>   // the page is currently loading something -> Don't enter a local event loop
>   // by launching a popupmenu!
>   if ( currentView->run() != 0 )
>       return;
> 
> Is it true to say that it is now safe to remove those lines? The popup will be 
> removed when the part destroys itself. If a page is currently loading, we are 
> actually in the same case as a redirection.

True, we handle this much better now, it should be fine to remove this.
Try in HEAD for a while, backport after some time if nobody hits problems with it.

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list