Patch: improved offline browsing for KDE-3.2.0

Tobias Anton TA at ESC-Electronics.de
Tue Feb 24 19:03:55 GMT 2004


Hi,
even though I like the idea of implementing the offline browsing mode very 
much, i'd suggest some changes for your next patch :)

- please leave out all changes that do not immediately correlate to the 
caching behaviour, i.e. omit general cleanup and debug output stuff
- ignore whitespace changes (option -w)

With that, one could judge better whether this patch does what it's supposed 
to do.

Even with these improvements, I think that the patch is simply too big to be 
reviewed quickly. It covers various libraries in three modules, so you should 
split it up in readable parts.

But basically, your patch is a good step into the right direction.

Cheers
Tobias

On Samstag, 21. Februar 2004 21:01, MG wrote:
> Hi,
>
> the attached patch improves offline browsing behavior in Konqueror. In
> short, it implements more aggressive caching. Every object is cached
> regardless of no-cache requests from webservers.  The patch even takes care
> of javascript.
>
> You'll see the effect of this patch on slashdot. Try surfing to slashdot,
> select offline browsing, kill Konqueror (important) and surf to slashdot
> again. The unpatched browser shows broken images, while with my patch it
> will show the page as visited.
>
> It also updates the cache configuration GUI. Now it is possible to select
> all five different HTTP cache strategies.
>
> Read the included README for details.
>
> Note: I am not subscribed, so please reply directly
>
> Greets,
>
> Matthias Grimrath

-- 
Tobias Anton
ESC GmbH & Co KG
Lindenstraße 25
D-63868 Großwallstadt
http://www.esc-electronics.de





More information about the kfm-devel mailing list