[patch] inlines
Germain Garand
germain at ebooksfrance.com
Fri Feb 13 22:23:58 GMT 2004
Le Vendredi 13 Février 2004 21:10, Dirk Mueller a écrit :
> On Friday 13 February 2004 20:37, Germain Garand wrote:
> > styleForElement in cssstyleselector, updateFirstLetter
>
> yeah :/ updateFirstLetter should be optional for fixing the regression
> though.
>
> > , and they have a new
> > _pseudoBits thing in the non-inherited flags
> > (not sure if that's needed...
>
> I didn't see a reason for it yet.
>
> > In the meantime, what about the simple attached patch for an easy
> > backport?
>
> well, that creates a default style.. an inheritFrom is missing.
>
yes, but in the actual use it's done just after the creation:
RenderStyle *CSSStyleSelector::styleForElement(ElementImpl *e)
{
...
if (!pseudoStyle)
{
pseudoStyle = style->addPseudoStyle(pseudoProps[i]->pseudoId);
if (pseudoStyle)
pseudoStyle->inheritFrom( style );
}
...
then the relevant pseudoProps are applied, so it looks all fine
> You're right, thats too much to merge right now. Ideally I'd like to have
> something working in head which we can backport for 3.2.1.
well, the patch does seem to work for me... :-}
More information about the kfm-devel
mailing list