[patch] konqi using searchline

David Faure faure at kde.org
Fri Dec 24 14:41:14 GMT 2004


On Friday 17 December 2004 22:03, Martin Koller wrote:
> On Sunday 12 December 2004 00:18, David Faure wrote:
> > I'm not sure what to decide - at least if it goes in it should be hidden by
> > default; think of the number of people typing a URL into the wrong
> > lineedit....
> 
> I've now finished the patch. The Toolbar does not show the widgets by default, 
> so one can activate it separately.

Great.

I hope it doesn't slow down listing of big directories too much - even when not shown,
the connect()s will trigger the filtering code, right?

Why did you remove the filterdir action from the toolbars? Was that intentional?
If yes it needs an OK from Dawit I guess, as the dirfilter maintainer.

Why create both an iconview-searchline and a listview-searchline when only
one is every going to be used? The plugin is created for each part, so the ctor
could find out which one it needs, and create that one, and leave the other to be 0.

> I'm attaching 2 patches, since the klistview has to be modified to ensure a 
> correct sequence of widget definition.
> 
> Please give me feedback if this is ok to commit, especially for the .desktop 
> and .rc file where I'm not the specialist.

The .desktop file looks fine, thanks for adding the info.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list