KHTML-Patch - show frame around not-yet-loaded images

[Leo Savernik]

Am Freitag, 17. Dezember 2004 13:33 schrieb Germain Garand:
> --- misc/helper.cpp     10 Nov 2004 13:26:33 -0000      1.58
> +++ misc/helper.cpp     17 Dec 2004 12:24:02 -0000
> @@ -25,6 +25,7 @@
[...]
> +/** finds out the background color of an element
> + * @param obj render object
> + * @return the background color. It is guaranteed that a valid color is
> returned. + */
> +QColor khtml::retrieveBackgroundColor(const RenderObject *obj)
> +{

Good idea to finally factor these out.

According the visual impression: Let's not forget that the loading image 
indicator is transient. It will pose no issues as soon as the page is fully 
loaded.

That said, if we show a loading image indicator at all, it should be 
immediately discernible as such (from normal borders, etc). That's why I opt 
for the Netscape version: It's clearly visible whose place the rectangle 
holds, and can be expected to be known by users (b/c of precedents in NN, Moz 
and IE).

This certainly includes the use of the image icon.

mfg
 Leo

PS.: It seems that tiny problems tend to cause huge discussions ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20041217/840cd487/attachment.sig>