[Patch] fixing text selection in compliance with style guide

Leo Savernik l.savernik at aon.at
Sun Apr 18 21:33:19 BST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag 18 April 2004 20:43 schrieb David Faure:
[...]
> Looks good to me (for the parts relating to the code I wrote).
> I like the fact that the hackish d->m_endOffset++ was investigated and
> rewritten correctly :)

Committed to head. Though I consider it stable, I'll leave it a while in HEAD 
to be evaluated before backporting.
>
> Maybe firstRunAt/lastRunAt could be documented as "helper functions
> for line-by-line selection" (one might wonder why this render-object-only
> code isn't in render/* otherwise).

It isn't actually needed anywhere else. I originally wanted to use 
RootInlineBoxes, but they are subtly broken for RenderListItems. Breaking 
selection of list items is no option, I guess ;-)

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFAguYQj5jssenUYTsRAvmjAKCflFoc9tJN3IVyMfkEWwxILVD+pgCeO4UA
Xo0ArbcKZnH/oLwCaG0SQBI=
=2ta8
-----END PGP SIGNATURE-----




More information about the kfm-devel mailing list