[Patch] improved text-decoration II

[Leo Savernik]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

This is basically the patch from Luciano Montanaro which replaces drawLine by 
fillRect, takes the QFontMetrics' line width into account, and makes 
underlining fully compliant to CSS 1 in transitional and strict modes.

The problem with this patch is that the text decoration is painted over any 
existing selection. Therefore, I shelled out painting of text selection into 
the PaintActionSelection phase. While this works great visually, it makes 
text selection feel slower. (The patch is slightly wrong. It should initiate 
the PaintActionSelection phase from RenderLayer::paintLayer, not from 
KHTMLView::drawContents, but I don't think this makes a difference speed 
wise.)

If that isn't bearable, should we take the IE approach to favour speed over 
correctness, and leave everything as is?

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFAgrrMj5jssenUYTsRAl00AJsGDkf7lDF7rpS/pVoKwo28VGNhqQCgrsCc
TsoI2kJx6Gj2mOjhlqhQ/gA=
=6RHX
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_rendering_2.diff
Type: text/x-diff
Size: 7391 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040418/cdef42c0/attachment.diff>