[Patch] outline fixes

Leo Savernik l.savernik at aon.at
Sun Apr 18 18:11:44 BST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

This patch moves the outline painting algorithm from RenderText to the more 
suitable RenderInline (in fact this is exactly what WebCore did).

As I merged the pieces from WebCore, I also merged their introduction of a 
PaintActionOutline phase. Is this a good idea?
I can also keep the outline painting part of the PaintActionForeground phase.

Furthermore, I changed NodeBaseImpl::setFocus to not set the m_focus flag on 
its children (exactly like Safari). With this change, only and nothing but 
the focussed element gets their :focus pseudo style applied -> only 
the :focus element gets its outline drawn, but not its children anymore which 
leads to a much cleaner look.

But maybe there's a reason why m_focus was inherited, that's why I'm asking.

Please review.

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFAgrbQj5jssenUYTsRApj/AJ9/zftqUnjzEPXfWbYOtdYpsWdGNACgjqTt
5z6SbWJ8Enalc5P5+QyGMZE=
=J1ZF
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_outline_1.diff
Type: text/x-diff
Size: 18319 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040418/3773e6f5/attachment.diff>


More information about the kfm-devel mailing list