Konqueror Context Specific Popup Menu

[Sashmit Bhaduri]

On Thursday 25 September 2003 11:37 am, David Faure wrote:
> What about calling it PopupFlags? ItemFlags sounds like it applies to a
> KFileItem, which isn't 100% correct (it applies to a list of them, or to a
> single URL, and anyway it's really specific to the popupmenu).
>
> NoClass could be called hmm, None, but that would clash with the X
> #defines, so maybe Default.
>

ok.. I renamed it DefaultPopupItems..  KParts::BrowserInterface::Default 
sounded weird for some reason to me :)

> The "ItemClass" name can be removed, just use an anonymous enum - all the
> methods take an ItemFlags (->PopupFlags) anyway.

done..

> Can you make sure
> that all the popupMenu variants are listed there?

What do you mean? Listed where?


> Yes it would be a good idea to clean this up, before it becomes part of
> the KDE-3.2 BC API.

done
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs.diff
Type: text/x-diff
Size: 5908 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030926/9d771c01/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase.diff
Type: text/x-diff
Size: 16407 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030926/9d771c01/attachment-0001.diff>