[Patch] KURL breaks data urls

Waldo Bastian bastian at kde.org
Mon Sep 15 08:39:35 BST 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 14 September 2003 22:45, Petter E. Stokke wrote:
> On Sun, 2003-09-14 at 22:26, Leo Savernik wrote:
> > Hello,
> >
> > KURL::KURL(base, relurl) breaks data urls. I traced it down to the call
> > of cleanPath which (wrongly) mangles a data url like
> >
> > data:text/html,blabla
> >
> > into
> >
> > data:/html,blabla
> >
> > So I wrote a fix that makes data urls exempt to this call. I'd like to
> > commit it, but if you have a better way to solve it, I'd like to know
> > about it.
>
> This is pretty closely related to something I've been working on - see
> http://bugs.kde.org/show_bug.cgi?id=62425 . Using the framework I
> propose in the latest attached patch, it'd just be a matter of skipping
> cleanPath altogether for non-URL URIs, or defining a processing mode for
> data URLs to mark them as exempt from cleanPath.
>
> It's time that patch was committed anyway. I asked for comments on
> kde-core-devel two weeks ago and got none, so I'll try again here. Does
> anyone mind my committing it?

Sorry for not responding sooner, yes I have seen the patch but I don't like 
it, I don't think it's a very clean solution.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/ZWy3N4pvrENfboIRAiqEAJ9yd6Tm9O9xbW2Q3tv4P79k4QfO4ACfYV9X
OqueiO5z+n182vhxchl9QYE=
=dl7A
-----END PGP SIGNATURE-----




More information about the kfm-devel mailing list