[Patch] KURL breaks data urls

Petter E. Stokke gibreel at project23.no
Sun Sep 14 21:45:09 BST 2003


On Sun, 2003-09-14 at 22:26, Leo Savernik wrote:
> Hello,
> 
> KURL::KURL(base, relurl) breaks data urls. I traced it down to the call of 
> cleanPath which (wrongly) mangles a data url like
> 
> data:text/html,blabla
> 
> into
> 
> data:/html,blabla
> 
> So I wrote a fix that makes data urls exempt to this call. I'd like to commit 
> it, but if you have a better way to solve it, I'd like to know about it.

This is pretty closely related to something I've been working on - see
http://bugs.kde.org/show_bug.cgi?id=62425 . Using the framework I
propose in the latest attached patch, it'd just be a matter of skipping
cleanPath altogether for non-URL URIs, or defining a processing mode for
data URLs to mark them as exempt from cleanPath.

It's time that patch was committed anyway. I asked for comments on
kde-core-devel two weeks ago and got none, so I'll try again here. Does
anyone mind my committing it?

-- 
Petter E. Stokke <gibreel at project23.no> http://www.gibreel.net/
PGP key: http://www.gibreel.net/key.asc
Fingerprint: 4FF3 12BD 692A 0FFF 984F  78DA 4776 81FB 1906 3A9F
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030914/a164175e/attachment.sig>


More information about the kfm-devel mailing list