Fwd: Re: [PATCH] 'sending unencrypted data' warning dialog regressions

[David Faure]

On Thursday 27 November 2003 15:08, Lubos Lunak wrote:
>  The attached patch should work correctly now for both DOM and QScrollView. I 
> tested again sequences of DOM events, and that small testcase from David 
> which filters out all DOM keypresses and prevents QScrollView scrolling. I 
> think the long comment in the patch explains all.

Looks good to me.
Thanks.

PS: tiny nitpick: I'd move that comment down one line, inside the if() :

     // If either keydown or keypress was accepted by a widget, or canceled by JS, stop here.
-    if ( accepted ) {
+    if ( dispatchKeyEvent( _ke )) {

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).