Konqueror Context Specific Popup Menu

[David Faure]

Hi Sashmit,

This patch completely removed the "stop animations" item in the RMB.

--- khtml/khtml_popupmenu.rc    18 Sep 2003 18:11:02 -0000      1.27
+++ khtml/khtml_popupmenu.rc    26 Sep 2003 05:13:33 -0000
@@ -22,8 +22,6 @@
   <Action name="viewimage" />
  </Menu>
  <Separator weakSeparator="1" />
- <Action name="stopanimations" />
- <Separator weakSeparator="1" />
  <Action name="security" />
  <Action name="setEncoding" />
 </Menu>

However this is apparently not intentionnal, since the code says
  if ( url.isEmpty() && !isImage )
  {
    KAction* copyAction = KStdAction::copy( d->m_khtml->browserExtension(), SLOT( copy() ), actionCollection(), "copy" );
    copyAction->setText(i18n("&Copy Text"));
    copyAction->setEnabled(d->m_khtml->browserExtension()->isActionEnabled( "copy" ));
    actionCollection()->insert( khtml->actionCollection()->action( "selectAll" ) );
    actionCollection()->insert( khtml->actionCollection()->action( "security" ) );
    actionCollection()->insert( khtml->actionCollection()->action( "setEncoding" ) );
    new KAction( i18n( "Stop Animations" ), 0, this, SLOT( slotStopAnimations() ),
                 actionCollection(), "stopanimations" );
  }

(i.e. bring up stopanimations when clicking on the page itself, not on a link
or image inside the page)

Is it ok if I revert the khtml_popupmenu.rc patch?

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions