On the KonqFrame::attach[Internal]() crash (Analysis, #58480 and others)..

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 May 2003 10:45, Waldo Bastian wrote:
> > > We might want to distinguish here between
> > > not finding any suitable factory and encountering load errors when
> > > attempting to load a factory.
> >
> > Yup. So why not leave the msgbox - at least when lastErrorMessage isn't
> > empty -, and leave the isNull check .. if that's enough to fix the
> > problem?
>
> Sort of, it will need a little bit more care because there is no guarantee
> that lastErrorMessage is actually caused by the createView call, it might
> still be set from some previous attempt to load a lib, so we should only
> call it if we know that we have indeed attempted to load a lib in
> createView.

Further investigation reveals that KonqFactory::createView already provides a 
message box when KLibLoader experiences problems, so I think the messagebox 
can be safely left out.

Will commit a cleaned up version of my original patch.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+zgWwN4pvrENfboIRApT2AKCZfnWTHoM5SZgb81ZysXXrRVsSswCgqPke
UYtUiSfDLJ8oO/URvUP0YpA=
=wVgs
-----END PGP SIGNATURE-----