On the KonqFrame::attach[Internal]() crash (Analysis, #58480 and others)..

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 May 2003 00:24, David Faure wrote:
> On Wednesday 21 May 2003 18:07, Waldo Bastian wrote:
> > On Thursday 15 May 2003 04:33, Maks Orlovich wrote:
> > > Obviously, this should be interrupted someplace along the way, but I
> > > don't know where the right spot is. I am willing to do the legwork
> > > if someone just wants to direct me on fixing this.
> >
> > The following patch fixes it for me.
>
> Idea is ok, but I don't like the fact that the error message (e.g. for
> undefined symbol in libkhtmlpart or whatever) isn't shown anymore. It was a
> convenient way to find out what's wrong.
>
> > We might want to distinguish here between
> > not finding any suitable factory and encountering load errors when
> > attempting to load a factory.
>
> Yup. So why not leave the msgbox - at least when lastErrorMessage isn't
> empty -, and leave the isNull check .. if that's enough to fix the problem?

Sort of, it will need a little bit more care because there is no guarantee 
that lastErrorMessage is actually caused by the createView call, it might 
still be set from some previous attempt to load a lib, so we should only call 
it if we know that we have indeed attempted to load a lib in createView.

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+zI4rN4pvrENfboIRAhidAKCaACIrJMWWRySF2CjMsimNDAT9eQCfXNGX
fjdevYCx4zsQLQX7Zt0LI/U=
=q7GT
-----END PGP SIGNATURE-----