[PATCH] JS Form Popups

Ralf Hoelzer ralf at well.com
Sat Jun 14 18:05:58 BST 2003


Here's another small patch to improve the popup blocking. Now nested framesets
are also searched for the target frame.

I also wanted to make the special targets (_top, etc.) case-insensitive but it 
doesn't work. Is this case-sensitive on purpose? Mozilla is case-insenstive. 
The code in khtml_part.cpp calls lower() first, but it doesn't seem to work:

<snip>
  QString frameName = args.frameName.lower();
  if ( !frameName.isEmpty() )
  {
    if ( frameName == QString::fromLatin1( "_top" ) )
    {
      emit d->m_extension->openURLRequest( url, args );
      return;
    }
...
</snip>

but <a href="http://cnn.com" target="_TOP">Test</a> creates a new window.

regards,

Ralf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: popup3.patch
Type: text/x-diff
Size: 1052 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030614/8609e1cd/attachment.patch>


More information about the kfm-devel mailing list