konq delete unification

[David Hugh-Jones]

On Tue, 2003-07-15 at 16:31, David Faure wrote:
> On Tuesday 15 July 2003 17:34, David Hugh-Jones wrote:
> > OK, so that will stop getting problems with e.g. shred.
> > 
> > But we have new slots (forceDel, forceTrash) that the browser extension
> > needs to know about, doesn't the BrowserExtension need to know about
> > them?
> 
> Why do you have those slots? What do they do, compared to del and trash?
> It seems to me that you're putting the logic in the wrong place, but then again
> I haven't thought about this much.

Well, that is possible, see earlier discussion. But I have 3 slots:
forcedel (yes this should just be called del but it's the way I hacked
it)
forcetrash (ditto)
del (does the default delete action, which may or may not involve
storing a copy in the trash)

I altered all the views to use the new slots, so unless there is a
"third party view" it's not a problem. Depends how much binary
compatibility you want to guarantee.

I don't see how to have a "standard delete action" without another slot.
We can't just use the two old ones and select between them, because
konq_operations wants to know if we are using the default action. (If
you're forcing a trash or delete you can be expected to know what you
are doing and not be told, e.g. "are you sure you want to trash this
remote file"?)

> 
> The issue I see with adding new slots, is that konq will try to call them,
> even on an old view, which doesn't implement them -> nothing will happen,
> and it will all look quite broken. This could happen in any 3rd-party
> file management view (not that I'm sure such a thing exists though).
> 
> IMHO the logic should be in konqmainwindow and/or in konqoperations,
> but not at the level of the communication with the view/part.
> 
> 
> [... I also think that half-hearted changes in this area will confuse users
> more than help them. We need a real trash implementation, and once we
> have one, some of the reasons for this change will not be true anymore,
> so the GUI will have to change once again..... Not good.
> OTOH smaller popup menus is a good goal, and most people I know use
> either del or trash, but never both, so merging makes some sense.]
> 
> -- 
> David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
> Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html