konq delete unification

David Faure faure at kde.org
Tue Jul 15 16:31:32 BST 2003


On Tuesday 15 July 2003 17:34, David Hugh-Jones wrote:
> OK, so that will stop getting problems with e.g. shred.
> 
> But we have new slots (forceDel, forceTrash) that the browser extension
> needs to know about, doesn't the BrowserExtension need to know about
> them?

Why do you have those slots? What do they do, compared to del and trash?
It seems to me that you're putting the logic in the wrong place, but then again
I haven't thought about this much.

The issue I see with adding new slots, is that konq will try to call them,
even on an old view, which doesn't implement them -> nothing will happen,
and it will all look quite broken. This could happen in any 3rd-party
file management view (not that I'm sure such a thing exists though).

IMHO the logic should be in konqmainwindow and/or in konqoperations,
but not at the level of the communication with the view/part.


[... I also think that half-hearted changes in this area will confuse users
more than help them. We need a real trash implementation, and once we
have one, some of the reasons for this change will not be true anymore,
so the GUI will have to change once again..... Not good.
OTOH smaller popup menus is a good goal, and most people I know use
either del or trash, but never both, so merging makes some sense.]

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html




More information about the kfm-devel mailing list