kparts/khtml crash on nsplugins

[George Staikos]

This fixes the crash, but the behaviour is quite wrong now.  It opens the new 
page in the frame where the button was instead of the main frame.  Yes I know 
this did work in the past because I regularily used this site for testing.  I 
think it was sometime over the last 2 days or so when it must have broken.

On Sunday 23 February 2003 18:56, Koos Vriezen wrote:
> On Sun, 23 Feb 2003, George Staikos wrote:
> > This is easy to reproduce for me.  I just updated khtml from HEAD.  go to
> > http://www.shockwave.com/ and click on "Games".  It always triggers an
> > assert for me.  Here is the backtrace:
>
> Did this work before yesterday? Because only frames are added to the
> partManager and here a requestURL comes from a nspluginviewer part. So I
> check for KHTMLPart parts should be needed (which fixes it btw.).
>
> diff -u -3 -p -r1.820 khtml_part.cpp
> --- khtml_part.cpp      23 Feb 2003 17:15:25 -0000      1.820
> +++ khtml_part.cpp      23 Feb 2003 23:53:39 -0000
> @@ -3251,7 +3251,7 @@ bool KHTMLPart::processObjectRequest( kh
>      }
>
>      //CRITICAL STUFF
> -    if ( child->m_part )
> +    if ( child->m_part && child->m_part->inherits( "KHTMLPart" ))
>      {
>        partManager()->removePart( (KParts::ReadOnlyPart *)child->m_part );
>        delete (KParts::ReadOnlyPart *)child->m_part;
>
> Koos

-- 

George Staikos