kparts/khtml crash on nsplugins

Koos Vriezen koos.vriezen at xs4all.nl
Sun Feb 23 23:56:56 GMT 2003


On Sun, 23 Feb 2003, George Staikos wrote:

>
> This is easy to reproduce for me.  I just updated khtml from HEAD.  go to
> http://www.shockwave.com/ and click on "Games".  It always triggers an assert
> for me.  Here is the backtrace:

Did this work before yesterday? Because only frames are added to the
partManager and here a requestURL comes from a nspluginviewer part. So I
check for KHTMLPart parts should be needed (which fixes it btw.).

diff -u -3 -p -r1.820 khtml_part.cpp
--- khtml_part.cpp      23 Feb 2003 17:15:25 -0000      1.820
+++ khtml_part.cpp      23 Feb 2003 23:53:39 -0000
@@ -3251,7 +3251,7 @@ bool KHTMLPart::processObjectRequest( kh
     }

     //CRITICAL STUFF
-    if ( child->m_part )
+    if ( child->m_part && child->m_part->inherits( "KHTMLPart" ))
     {
       partManager()->removePart( (KParts::ReadOnlyPart *)child->m_part );
       delete (KParts::ReadOnlyPart *)child->m_part;

Koos





More information about the kfm-devel mailing list