[PATCH] improved text-decoration

Leo Savernik l.savernik at aon.at
Mon Dec 15 21:52:26 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Montag, 15. Dezember 2003 18:17 schrieb Luciano Montanaro:
[...]
> Here it is. However, I'm not sure I got it right for the render_line.cpp
> part, I tried that patch alone and I could not see any difference vs. the
> original version. In particular, I'm not doubtful about the fontMetrics()
> call. How can I trigger a call to paintDecorations()?
>
You uncovered a bug here due to a partial Safari merge. The merge must be 
completed for InlineFlowBox::paintDecorations to work satisfactorily. Now it 
is called in strict mode, but it doesn't draw any decorations. For 
compensation InlineTextBox::paintDecoration is called in strict mode, too 
(but eventually shouldn't).

I tried to quick-fix the bug, but it demands just another merge from Safari 
which I cannot account for at this stage of the freeze.

I changed your patch a little bit, and I like it. However, is this a bug fix, 
or a wishlist item? If it's the latter, it has to wait until after KDE 3.2.
>
> Luciano
>
> > mfg
> > 	Leo

PS.: When attempting to send you private mails I get:
"Connected to 62.211.72.32 but sender was rejected.
Remote host said: 550 mail not accepted from blacklisted IP address"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/3i0bj5jssenUYTsRAgZdAJ46zpKtbIWZ6022BdpllWMBE7AcnQCeJn4a
s24g5nPSjPOZtIvDlLOtU9M=
=LsU2
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list