[PATCH] #69559

[Lubos Lunak]

On Monday 08 of December 2003 20:32, David Faure wrote:
> On Monday 08 December 2003 20:08, Lubos Lunak wrote:
> > On Monday 08 of December 2003 18:10, Koos Vriezen wrote:
> > > On Mon, Dec 08, 2003 at 06:02:55PM +0100, Lubos Lunak wrote:
> > > > On Monday 08 of December 2003 17:50, Koos Vriezen wrote:
> > > > > On Fri, Dec 05, 2003 at 03:17:42PM +0100, Lubos Lunak wrote:
> > > > > >  Oh, and this time I also didn't forget the reverse mapping in
> > > > > > RenderWidget ;).
> > > > >
> > > > > But frames are forgotten again, no?
> > > > > (I use http://java.sun.com/j2se/1.4.2/docs/api/index.html when
> > > > > working on kjas)
> > > >
> > > >  I thought that has been already fixed by David? Do you have any
> > > > problems with them?
> > >
> > > They don't scroll with the scroll keys.
> > >
> > > > > Koos
> >
> >  I've found the reason, it was this David's change
> > http://lists.kde.org/?l=kde-cvs&m=107064986608639&w=2 . Specifically, the
> > attached patch fixes your problem. However, I have absolutely no idea
> > what that code does, so the patch may be wrong *shrug*. I wonder why the
> > dispatching is done there, as if the event is not filtered out here, the
> > dispatching will be done once again in KHTMLView, but then I have no clue
> > about this.
>
> Hmm, indeed. I wonder if this code isn't simply a leftover from the old way
> of doing things (i.e. before Lars' changes). Could someone test removing
> the whole "case:" in this switch?

 I removed the whole event filter, and I didn't notice any problem. Both 
keyboard and focus related things seemed to work, both with and without 
frames. No serious testing though, I just clicked few times, pressed keys, 
watched the active frame/widget etc.[*], so if you remove it just because I 
said it works, and it will break something, I'll pretend I know almost 
nothing about KHTML. Hmm, wait, no need to pretend that.

* - Is there some better way how to test it?

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/