[PATCH] #69559

Koos Vriezen koos.vriezen at xs4all.nl
Mon Dec 8 20:14:42 GMT 2003


On Mon, Dec 08, 2003 at 08:32:41PM +0100, David Faure wrote:
> On Monday 08 December 2003 20:08, Lubos Lunak wrote:
> > On Monday 08 of December 2003 18:10, Koos Vriezen wrote:
> > > On Mon, Dec 08, 2003 at 06:02:55PM +0100, Lubos Lunak wrote:
> > > > On Monday 08 of December 2003 17:50, Koos Vriezen wrote:
> > > > > On Fri, Dec 05, 2003 at 03:17:42PM +0100, Lubos Lunak wrote:
> > > > > >  Oh, and this time I also didn't forget the reverse mapping in
> > > > > > RenderWidget ;).
> > > > >
> > > > > But frames are forgotten again, no?
> > > > > (I use http://java.sun.com/j2se/1.4.2/docs/api/index.html when working
> > > > >  on kjas)
> > > >
> > > >  I thought that has been already fixed by David? Do you have any problems
> > > > with them?
> > >
> > > They don't scroll with the scroll keys.
> > >
> > > > > Koos
> > 
> >  I've found the reason, it was this David's change 
> > http://lists.kde.org/?l=kde-cvs&m=107064986608639&w=2 . Specifically, the 
> > attached patch fixes your problem. However, I have absolutely no idea what 
> > that code does, so the patch may be wrong *shrug*. I wonder why the 
> > dispatching is done there, as if the event is not filtered out here, the 
> > dispatching will be done once again in KHTMLView, but then I have no clue 
> > about this.
> 
> Hmm, indeed. I wonder if this code isn't simply a leftover from the old way
> of doing things (i.e. before Lars' changes). Could someone test removing
> the whole "case:" in this switch?

Commenting out  QEvent::KeyPress/QEvent::KeyRelease makes it work for me, thanks.
(not that I've followed this event discussion close enough to see if it not
 regresses somewhere else btw.)

Koos




More information about the kfm-devel mailing list