MMB-pasting url into page treated wrong

Pascal Létourneau pletourn at globetrotter.net
Tue Apr 29 18:18:49 BST 2003


On April 11, 2003 08:29, David Faure wrote:
> On Friday 11 April 2003 14:26, Oswald Buddenhagen wrote:
> > moin,
> >
> > open any http:// location, put a file:/ url into PRIMARY and MMB-paste
> > it into the html render area. you'll get a security warning. the problem
> > seems to be, that the MMB-pasting is treated like a link inside the page
> > instead of an url entered in the location bar.
>
> Pascal Letourneau sent me this patch to fix this bug.
> (I'd like Dirk to comment on the referrer stuff though.)
>
> Index: khtml_part.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/khtml/khtml_part.cpp,v
> retrieving revision 1.837
> diff -u -3 -p -r1.837 khtml_part.cpp
> --- khtml_part.cpp      8 Apr 2003 17:11:26 -0000       1.837
> +++ khtml_part.cpp      8 Apr 2003 19:20:10 -0000
> @@ -4988,10 +4988,7 @@ void KHTMLPart::khtmlMouseReleaseEvent(
>
>             || uriType == KURIFilterData::NET_PROTOCOL )
>
>        {
>          KURL u = m_filterData.uri();
> -        QString savedReferrer = d->m_referrer;
> -        d->m_referrer = QString::null; // Disable referrer.
> -        urlSelected(u.url(), 0,0, "_top");
> -        d->m_referrer = savedReferrer; // Restore original referrer.
> +        emit d->m_extension->openURLRequest( u.url() );
>        }
>      }
>    }

Does the lack of objections means I can commit the patch?

Pascal Létourneau




More information about the kfm-devel mailing list