[PATCH] Multiple redirections and KDirListerCache

[Hamish Rodda]

On Mon, 2 Sep 2002 09:21 pm, David Faure wrote:
> Looks good, but now I'm confused - why does this version work, whereas
> mine didn't? ;}
> (oldUrl is treated the same way in both...... ok, not newUrl)

My apologies, that assert I triggered requires the loading of both my test 
cases in sequence to reproduce; my original patch was prone to the same bug 
too.  There is some complex interaction going on here, though the last patch 
is free of it; I guess I need to investigate further before it's committed... 
:(

> > Now that I look closer though it would appear to be KDirOperator's fault
> > for not calling stat()...?
>
> Not really. As I said below, it can't do anything with files anyway, so
> it's better (faster) if it just issues a listDir() command, and reacts on
> errors, instead of first ensuring it's a dir.

I agree.

Cheers,

Hamish.