[PATCH] Multiple redirections and KDirListerCache

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 02 September 2002 13:04, Hamish Rodda wrote:
> On Mon, 2 Sep 2002 08:39 pm, David Faure wrote:
> > Huh? All the urls within KDirLister are supposed to be normalized
> > to "no trailing slash". forgetDirs() does use url(-1) ... and I just
> > checked all the lines adding entries to urlsCurrentlyHeld[], they all use
> > url(-1) too.
> 
> Ah, I see... the attached patch does this the "right way" now.  It's a bit 
> messy because I couldn't modify the const url directly.  How's this?

Looks good, but now I'm confused - why does this version work, whereas
mine didn't? ;}
(oldUrl is treated the same way in both...... ok, not newUrl)

> KFileDialog.cpp, line 1107:
> 
>     // typing forward, ending with a / -> cd into the directory
>     else if ( autoDirectoryFollowing &&
>               text.at(text.length()-1) == '/' && ops->url() != text ) {
>         d->selection = QString::null;
>         setURL( text, false );
>     }

Oh, ok ;-)

> Now that I look closer though it would appear to be KDirOperator's fault for 
> not calling stat()...?

Not really. As I said below, it can't do anything with files anyway, so it's
better (faster) if it just issues a listDir() command, and reacts on errors,
instead of first ensuring it's a dir.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9c0nS72KcVAmwbhARArGAAKCEGnMdIahXKr0J7RErSJrjslpCtgCglVNx
sJoybXeIOAYUp1URCflLCCw=
=rlTr
-----END PGP SIGNATURE-----