[PATCH] spiggl.de

Lars Knoll lars at trolltech.com
Wed Oct 23 11:59:39 BST 2002


> Hi,
>
> snippet from a patch to fix http://www.spiggl.de/ :
>
> rendering/render_flow.cpp:
> -    // take care in case we inherited floats
> -    if (child && floatBottom() > m_height)
> -       child->setLayouted(false);
> -
> -
>  //     QTime t;
>  //     t.start();
>
>      while( child != 0 )
>      {
>
> -        // make sure we relayout children if we need it.
> -        if ( relayoutChildren || floatBottom() > m_y ||
> +        // make sure we relayout children if we need it,
> +        // like inherited floats or percentage based widths.
> +        if ( relayoutChildren || floatBottom() > m_height ||
>
>
> The code for recalculating the floats seems to be a huge mess, I'm not sure
> what else I broke now.
>
> A testcase which reproduces the problem for me is appended. This bug is
> extremely fragile and extremely difficult to reproduce, changing one
> character in this testcase already makes it work.

The fix looks good. IMO it can't break anything as it will only lead to 
additional relayouts of children. Please apply.

Cheers,
Lars





More information about the kfm-devel mailing list