[PATCH] spiggl.de

Dirk Mueller mueller at kde.org
Tue Oct 22 16:15:37 BST 2002


Hi, 

snippet from a patch to fix http://www.spiggl.de/ :

rendering/render_flow.cpp:
-    // take care in case we inherited floats
-    if (child && floatBottom() > m_height)
-       child->setLayouted(false);
-
-
 //     QTime t;
 //     t.start();
 
     while( child != 0 )
     {
 
-        // make sure we relayout children if we need it.
-        if ( relayoutChildren || floatBottom() > m_y ||
+        // make sure we relayout children if we need it, 
+        // like inherited floats or percentage based widths.
+        if ( relayoutChildren || floatBottom() > m_height ||


The code for recalculating the floats seems to be a huge mess, I'm not sure 
what else I broke now. 

A testcase which reproduces the problem for me is appended. This bug is 
extremely fragile and extremely difficult to reproduce, changing one 
character in this testcase already makes it work. 



-- 
Dirk (received 413 mails today)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021022/756a5299/attachment.html>


More information about the kfm-devel mailing list