RenderStyle::setContent

[Simon Hausmann]

Hi,

khtml crashes at

http://www.mathworks.com/access/helpdesk/help/toolbox/stats/geomean.shtml .

#0  0x4182f25f in khtml::RenderStyle::setContent(DOM::DOMStringImpl*) (this=0x82965c0, s=0x0) at ../../../../src/kdelibs/khtml/misc/shared.h:12
#1  0x4187bb65 in khtml::CSSStyleSelector::applyRule(DOM::CSSProperty*) (this=0x8285e20, prop=0x8282688) at ../../../../src/kdelibs/khtml/css/css_valueimpl.h:188
#2  0x41878b16 in khtml::CSSStyleSelector::styleForElement(DOM::ElementImpl*, int) (this=0x8285e20, e=0x82862b0, state=0)
    at ../../../../src/kdelibs/khtml/css/cssstyleselector.cpp:398
#3  0x417ec374 in DOM::ElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x82862b0, change=Force) at ../../../../src/kdelibs/khtml/xml/dom_docimpl.h:212
#4  0x41809779 in DOM::HTMLElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x82862b0, ch=NoChange) at ../../../../src/kdelibs/khtml/html/html_elementimpl.cpp:167
#5  0x417ec464 in DOM::ElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x8288020, change=Force) at ../../../../src/kdelibs/khtml/xml/dom_elementimpl.cpp:389
#6  0x41809779 in DOM::HTMLElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x8288020, ch=NoChange) at ../../../../src/kdelibs/khtml/html/html_elementimpl.cpp:167
#7  0x417ec464 in DOM::ElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x819efb8, change=Force) at ../../../../src/kdelibs/khtml/xml/dom_elementimpl.cpp:389
#8  0x41809779 in DOM::HTMLElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x819efb8, ch=NoChange) at ../../../../src/kdelibs/khtml/html/html_elementimpl.cpp:167
#9  0x417ec464 in DOM::ElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x81a2090, change=Force) at ../../../../src/kdelibs/khtml/xml/dom_elementimpl.cpp:389
#10 0x41809779 in DOM::HTMLElementImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x81a2090, ch=NoChange) at ../../../../src/kdelibs/khtml/html/html_elementimpl.cpp:167
#11 0x417de29c in DOM::DocumentImpl::recalcStyle(DOM::NodeImpl::StyleChange) (this=0x819f108, change=Force) at ../../../../src/kdelibs/khtml/xml/dom_docimpl.cpp:911
#12 0x417e1741 in DOM::DocumentImpl::updateStyleSelector() (this=0x819f130) at ../../../../src/kdelibs/khtml/xml/dom_docimpl.cpp:1747
#13 0x41806a84 in DOM::HTMLLinkElementImpl::setStyleSheet(DOM::DOMString const&, DOM::DOMString const&) (this=0x82deef0, url=@0x0, sheetStr=@0x0)
    at ../../../../src/kdelibs/khtml/xml/dom_nodeimpl.h:212
#14 0x41884220 in khtml::CachedCSSStyleSheet::checkNotify() (this=0x8273e7c) at ../../../../src/kdelibs/khtml/misc/loader.cpp:184
#15 0x41884190 in khtml::CachedCSSStyleSheet::data(QBuffer&, bool) (this=0x8273e30, buffer=@0x400cada8) at ../../../../src/kdelibs/khtml/misc/loader.cpp:171
[...]

Obviously setContent is called with a 0 string impl, as
CSSValueImpl::getValueString returns 0. Where's the right place to put the null
pointer check? :) In setContent?

Simon