Patch: Crash: blocking JS alert and deleting a window

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 18 October 2002 19:18, Koos Vriezen wrote:
> On Fri, 18 Oct 2002, David Faure wrote:
> 
> > On Friday 18 October 2002 18:55, Koos Vriezen wrote:
> > > +  QObjectList *dlgs = d->m_view->topLevelWidget()->queryList("QDialog");
> > > +  for (QObject *dlg = dlgs->first(); dlg; dlg = dlgs->next())
> > > +    static_cast<QDialog*>(dlg)->close();
> > > +  delete dlgs;
> > > +
> > >    return true;
> > >  }
> >
> > Great, thanks for the testing.
> >
> > But going up to the top-level-widget is too much, no?
> > Imagine a splitted Konqueror window, two HTML views, one shows a dialog,
> > the other one is aborted -> closeURL -> the dialog gets closed?
> 
> Ok, I remove that....yes still no crashes.
Good.

> Was it ok in the
> ecma/kjs_window patch (topLevelWidget I mean)?
No, same problem there, I'd say.

> (otherwise we might introduce a KHTMLView::closeChildDialogs())
Sounds good.

BTW the next one is #44547 ;-)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9sETy72KcVAmwbhARAj5DAJ45nBBOydbIKA41eP2FxKchdRkicACglaBf
y4ddlnebsjmW10qFRlQcc6E=
=iuwm
-----END PGP SIGNATURE-----