Patch: Crash: blocking JS alert and deleting a window
Koos Vriezen
koos.vriezen at xs4all.nl
Fri Oct 18 18:18:29 BST 2002
On Fri, 18 Oct 2002, David Faure wrote:
> On Friday 18 October 2002 18:55, Koos Vriezen wrote:
> > + QObjectList *dlgs = d->m_view->topLevelWidget()->queryList("QDialog");
> > + for (QObject *dlg = dlgs->first(); dlg; dlg = dlgs->next())
> > + static_cast<QDialog*>(dlg)->close();
> > + delete dlgs;
> > +
> > return true;
> > }
>
> Great, thanks for the testing.
>
> But going up to the top-level-widget is too much, no?
> Imagine a splitted Konqueror window, two HTML views, one shows a dialog,
> the other one is aborted -> closeURL -> the dialog gets closed?
Ok, I remove that....yes still no crashes. Was it ok in the
ecma/kjs_window patch (topLevelWidget I mean)? (otherwise we might
introduce a KHTMLView::closeChildDialogs())
Koos
More information about the kfm-devel
mailing list