PATCH: Fix for BR#48679: Proxy options lost after switching proxy use off and on

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 07 November 2002 11:03, David Faure wrote:
> On Wednesday 06 November 2002 02:13, Dawit A. wrote:
> > Please review the first two patches that fix the bug mentioned in the subject.
> > They address the core problem outlined in the bug report with the exception
> > of the request to automatically select the previous proxy setting when it is
> > disabled and then re-enabled again. Though easy enough to fix several ways,
> > it is too late at this point.
> >
> > The last two patches are not really siginficant but something I run into when
> > fixing the above bug.  The KProxyDlg one is trivial and might not even be
> > necessary.  The KSaveIOConfig one is a bit more significant, but it reduces
> > the number of times the same config file have to be read from say the proxy
> > config module (it is used by all the config dialogs in the kcontrol/kio
> > module).  None of these two are really essential and can wait for post-3.1 if
> > there are objections.
> 
> kenvvarproxydlg.diff :
> - setMinimumSize looks wrong and/or unnecessary
> - an i18n string is changed! Don't apply that!

Grrr, now I see you applied those patches already :(
I reverted the i18n string change, and made the delete d->config change.
What do you think about my other objections?

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9yjy972KcVAmwbhARAnSwAJ4qY15yeqW2GR5a7AHrAyqtJ8ZR6gCglglQ
ZJo/sAMZjCRcTvYg/tGwTCU=
=KwAs
-----END PGP SIGNATURE-----