good news: nspluginviewer HTTP POST Support

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 05 November 2002 20:45, Till Krech wrote:
> On Tuesday 05 November 2002 20:20, David Faure wrote:
> >
> > Hmm is it supposed to _return_ a string from that method, and use it as the
> > contents of the frame, or simply to call that method?
> No, it isnt supposed to return something. it basically does a javascript  
> window.open(...)
Ok. I wonder if there aren't cases where the browser is supposed to show
the result of the function, when it does return something. That's how it
works (or should work) in many other places.

> > If the latter, this patch might be enough. 
> And yes, it works in this case.
> Can it break something else ?

No, it can't.
Old behaviour:
* framename set -> openURLRequest/createNewWindow (fails with javascript: urls)
* framename not set -> javascript: handled (ignoring framename), then the normal case
New behaviour:
* javascript: urls handled first (not better nor worse than before, still ignoring framename)
* framename set -> openURLRequest/createNewWindow
* framename not set -> javascript: handled, then the normal case

I guess it can do for now (unless Dirk objects :). 
IMHO the real fix is to call requestFrame, at least when the framename 
is empty, or points to an existing childframe. Not sure what should happen
with _parent though, or _blank .... especially when the JS returns something.
Many cases to test...

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9yCNi72KcVAmwbhARAgtBAKCP+rUiVlq8tceVb1+ZJP7rTilXzQCcDFag
thvTiQ483CwUftV6lEU+OJw=
=3/ua
-----END PGP SIGNATURE-----