PATCH (Re: Konqueror and multiple submit buttons)

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 05 November 2002 02:34, Dirk Mueller wrote:
> On Mon, 04 Nov 2002, David Faure wrote:
> 
> > > > Looking into how to fix, patch coming up soon.
> > Long patch, but only because it's moving some code to separate methods. 
> 
> Patch is wrong. If it would be that simple it would have been implemented 
> years ago ;-)
> 
> IE's behaviour is quite weird on this one. the submit button will not be 
> submitted for example when there is only one lineedit instead of two. 

Then it's the "specification" of the patch that's wrong, not the patch itself.
It does exactly what it's supposed to do: it activates the first submit button when
pressing Return.

But indeed IE works differently if there's only one lineedit.
How can the number of lineedits influence this? That's very screwed up...
I tried to find if it has to do with the 'default button' (the one with a bigger border),
but no, after tabbing to 'two' and clicking in a lineedit, 'one' becomes the default
one again.
I see no logic here. I'm all for IE compat when we can... but here? I know you
don't like Mozilla much, but it doesn't have this nonsensical behaviour.

> Besides some of the code rehubbing seems wrong to me judging by looking at 
> the diff. 
? I only moved code to separate methods, to be able to call it from the new method,
no behaviour change (for other cases than pressing Return).

> but I haven't figured that out. will have a look at it tomorrow. 
Yes, I know you want to do everything, but the reason I'm trying to fix the bugs
I can fix, is so that you can concentrate on those bugs I can't fix (like the
rendering or events related bugs, see last reassignments) - hmm or the
RenderFlow::addChild assert failure on http://kde.homeip.net/43094.html
(note that it uses http://kde.homeip.net/default.css, no crash without it)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9x7u172KcVAmwbhARAmeKAJ9MGDtJgTzUi+dLznUu86ztdtxTYwCgnR6U
ijs7kPHFVEWa8dlv58zDIuM=
=nJhj
-----END PGP SIGNATURE-----