[PATCH] konqueror crash recovery

[David Faure]

On Thursday 16 May 2002 01:12, Alexander Kellett wrote:
> This is a first version of a patch for adding
> crash recovery to konqueror. Currently other
> than keditbookmarks there is no interface
> to the crash recovery.
> 
> The patch works by logging urls opens/closes
> with view id's (the pointers).
> 
> Further doubtfull improvements:
>    open the file 'raw' to stop possible buffering problems?
>    shorten the written strings
>    optimize by replacing iostream use with sprintf
>    write the urls in a alternate way, are how are url's encoded anyway?
> 
> Anyway, this code path is so infrequently followed 
> that other than the first and last I can't see any 
> real speed related need to improve the current 
> level of simplicity.

I have nightmares when I see QTextStream, remembering all the problems it gave us
in the past - but maybe that's fixed in Qt 3. Anyway, opening the file raw and not
using QTextStream sounds faster and safer to me, but maybe for no good reason.

The patch is only about saving the state of Konqueror (while using it
and not when it crashes, which is good because it's safer than a crashhandler,
but which has a very small performance hit) - I don't see the code for recovering
after a crash ... is that in keditbookmarks? How does the user do, to recover
after a crash?

For your point 4: writing url() and reading that into a KURL is ok, that's
two-ways.
One thing is that:  bool ? QString : ""  doesn't compile on some picky compilers,
better use QString::null so that the two expressions are really of the same type.

-- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KDE, Making The Future of Computing Available Today