kget<-->konqueror integration

Simon Hausmann hausmann at kde.org
Wed Jun 19 08:20:28 BST 2002


On Tue, Jun 18, 2002 at 09:29:20PM +0200, Patrick wrote:
[...] 

Three minor thoughts about your patch:

* I think in the khtml_ext.cpp change the KConfig object is leaked

* You might probably want to open konquerorrc read-only, so passing 
  'true' instead of 'false' as second argument to the
  KConfig constructor

* How about reading a 'DownloadManager' field from the config file,
  containing the name of the program (with %f, %u, etc. in the
  cmdline) which handles the download. If the field is non-empty
  then that one is to be used. That way there would be no need to
  hardcode 'kget' into the sources.


Simon




More information about the kfm-devel mailing list