[Patch] Webdav properties in UDSAtoms

Best, Jan-Pascal van j.p.vanbest at tbm.tudelft.nl
Mon Jun 3 08:33:28 BST 2002


Hamish Rodda wrote:
> > > For now I've just append the required fields onto the
> > > davRequestResponse XML provided by the app.
> > > The format of the xml provided
> > > shoud be that the opening <prop> tag is supplied, in case it
> > > needs to define
> > > any additional namespaces, but not the closing </prop> (so I
> > > can append the
> > > other elements we need), sound right?
> >
> > Sounds a bit awkward, sending incomplete XML elements like that.
> > But I can't think of a better way.
> 
> Yeah, well the better way is to do it properly: parse the 
> input we receive and 
> append missing items. Unfortunately this is more overhead for 
> "niceness", probably unnecessarily?
You're complete right, that would we ludicrous to do in http.cc
and thus not really a better way.

> Well, let me know how it goes as you test it, and when it's 
> safe to commit.
I'll give it a whizz.

>From looking at the patch, there's still some issues IMO:
- I think we should leave out the special case handling for 
  empty "davRequestResponse" metadata. If an application is
  smart enough to send this request, it's smart enough to
  enter the "<D:prop><allprop/>", right?
- As a workaround for the unfinished <prop> element awkwardness,
  can't we require from the application side that the standard
  elements (creationdate,getcontentlength,etc.) should always 
  be queried? That would make the http.cc part so much simpler.
  Does anyone know what would go wrong if this application 
  doesn't comply, but also does not make use of the returned
  UDS creation date etc.? I'll also be trying this.

BTW: Next will probaly be the PROPPATCH method, when I start thinking
about write access to Exchange server (shudder). I guess that will have 
to be special() function? Another idea might be to create a generic
WebDavJob class, and the appropriate KIO::webdav() function, with
as arguments the URL, the HTTP_METHOD and the XML request. The result
would be the XML reply. Would this conflict with the KIO concepts
(David?)

Cheers

Jan-Pascal




More information about the kfm-devel mailing list