patch for bug 27362 : put redirected URLs in history

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 25 July 2002 06:38, Carsten Pfeiffer wrote:
> On Wednesday 24 July 2002 01:08, Con Hennessy wrote:
> 
> [Konqueror issues are handled on kfm-devel]
> 
> Hi,
> 
> > The bug http://bugs.kde.org/db/27/27362.html is marked as a duplicate
> > and is closed. However I could not find any other bug which may be a
> > duplicate of it, also the problem itself is not resolved.
> >
> > Basically the problem is that when a URL is actually redirected,
> > this URL is never added to the history, and therefore is never
> > marked as being "visited" when you go back to the original page.
> > As an example following any news link from http://newshub.com/tech
> > or any link from http://www.freshmeat.net/.
> >
> > The patch files below, are very basic :
> > 1) to the class BrowserRun a slotRedirection slot is added and
> >    connected with the redirection signal from the KIO::TransferJob;
> > 2) to the class KonqRun the virtual method defined above (slotRedirection)
> >    is redefined so that the pending URL ( i.e. the one which we are
> >    being redirected from ) is confirmed and the new URL ( i.e. the
> >    one we are being directed to ) is added as "pending".
> >
> > These changes work for me (on newshub but now I'm not completely sure
> > whether they do on freshmeat ?). I am not sure if KonqRun is the right
> > class to add the code for the history.
> 
> Thanks for the patch! Unfortunately, it causes a binary incompatibility in
> KParts::BrowserRun (we can't add a new virtual method). However, looking at
> BrowserRun::scanFile(), the job is assigned to KRun's m_job, so KonqRun could
> simply reimplement scanFile(), call BrowserRun::scanFile and then connect()
> to the redirected() signal.
> 
> New patch attached. Unfortunately, David Faure is on vacation at the moment,
> so it might take a little while to get his comment.

Patch looks fine to me, please commit.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice 1.2 RC1 is slightly delayed. Stay tuned.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9QQwx72KcVAmwbhARAmKbAJsG1zz1INiD7FJkv6vR8HL6VrTQawCghG8I
ayJuOFsGn5kGifCuuUwnrKI=
=56wG
-----END PGP SIGNATURE-----